Add graphs/frequent_pattern_graph_miner.py#1866
Merged
Merged
Conversation
cclauss
requested changes
Apr 15, 2020
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. It needs some changes to meet our standards.
cclauss
reviewed
Apr 15, 2020
cclauss
reviewed
Apr 15, 2020
cclauss
reviewed
Apr 15, 2020
cclauss
reviewed
Apr 15, 2020
cclauss
reviewed
Apr 15, 2020
Co-Authored-By: Christian Clauss <cclauss@me.com>
Co-Authored-By: Christian Clauss <cclauss@me.com>
cclauss
reviewed
Apr 15, 2020
cclauss
reviewed
Apr 15, 2020
cclauss
reviewed
Apr 15, 2020
cclauss
reviewed
Apr 15, 2020
cclauss
requested changes
Apr 18, 2020
Co-Authored-By: Christian Clauss <cclauss@me.com>
Co-Authored-By: Christian Clauss <cclauss@me.com>
Co-Authored-By: Christian Clauss <cclauss@me.com>
Co-Authored-By: Christian Clauss <cclauss@me.com>
cclauss
reviewed
Apr 18, 2020
Co-Authored-By: Christian Clauss <cclauss@me.com>
Member
|
Nice! Test are passing again. (LGTM can be ignored) |
Co-Authored-By: Christian Clauss <cclauss@me.com>
Member
|
OK. Now we appear in the Travis tests Now please remove the second test that was designed to fail. |
cclauss
reviewed
Apr 18, 2020
cclauss
reviewed
Apr 18, 2020
cclauss
reviewed
Apr 18, 2020
Member
|
https://travis-ci.com/github/TheAlgorithms/Python/builds/161205503#L1270 You can run these tests on your own computer with the command: |
cclauss
reviewed
Apr 21, 2020
cclauss
changed the title
cclauss
reviewed
Apr 21, 2020
Co-Authored-By: Christian Clauss <cclauss@me.com>
Contributor
Author
|
All changes have made. |
Member
|
Could you please add doctests to at least some of these?
|
Contributor
Author
|
cclauss
reviewed
Apr 25, 2020
| @@ -100,7 +100,7 @@ def get_support(cluster :Dict[int,Dict[str,List[str]]])-> List[float]: | |||
| ''' | |||
| Returns support | |||
| >>> get_support({5: {'11111': ['ab', 'ac', 'df', 'bd', 'bc']}, 4: {'11101': ['ef', 'eg', 'de', 'fg'], '11011': ['cd']}, 3: {'11001': ['ad'], '10101': ['dg']}, 2: {'10010': ['dh', 'bh'], '11000': ['be'], '10100': ['gh'], '10001': ['ce']}, 1: {'00100': ['fh', 'eh'], '10000': ['hi']}}) | |||
Member
There was a problem hiding this comment.
Lines in Python should be 88 characters max. Lines that can not be read in GitHub without left/right scrolling (127 characters) need to be wrapped for readability.
Member
|
I will review tonight and then I think then we can land this one. Thanks for your persistence! |
Contributor
Author
|
can you pls merge the file? |
cclauss
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.